linux-kernel - Re: [PATCH] virt: vbox: Use current_uid() in vbg_misc_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Aug 2020 16:35:13 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Denis Efremov <efremov@...ux.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virt: vbox: Use current_uid() in
 vbg_misc_device_requestor()

Hi,

On 8/24/20 2:53 PM, Denis Efremov wrote:
> Modify vbg_misc_device_requestor() to use current_uid() wrapper.
> 
> Signed-off-by: Denis Efremov <efremov@...ux.com>

Thank you, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


> ---
>   drivers/virt/vboxguest/vboxguest_linux.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c
> index 32c2c52f7e84..6215a688edaf 100644
> --- a/drivers/virt/vboxguest/vboxguest_linux.c
> +++ b/drivers/virt/vboxguest/vboxguest_linux.c
> @@ -35,7 +35,7 @@ static u32 vbg_misc_device_requestor(struct inode *inode)
>   			VMMDEV_REQUESTOR_CON_DONT_KNOW |
>   			VMMDEV_REQUESTOR_TRUST_NOT_GIVEN;
>   
> -	if (from_kuid(current_user_ns(), current->cred->uid) == 0)
> +	if (from_kuid(current_user_ns(), current_uid()) == 0)
>   		requestor |= VMMDEV_REQUESTOR_USR_ROOT;
>   	else
>   		requestor |= VMMDEV_REQUESTOR_USR_USER;
>