linux-kernel - Re: [PATCH] ARM: dts: imx6sx-sdb: Add headphone detection for sound card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB3342064B54636847F4737442E3560@VI1PR0402MB3342.eurprd04.prod.outlook.com>
Date:   Mon, 24 Aug 2020 07:56:25 +0000
From:   "S.j. Wang" <shengjiu.wang@....com>
To:     Shawn Guo <shawnguo@...nel.org>, Fabio Estevam <festevam@...il.com>
CC:     Rob Herring <robh+dt@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Add headphone detection for sound
 card

Hi Shawn, Fabio

> >
> > > I would like to know your opinion, should I move headphone detect
> > > GPIO To audmux group?
> >
> > What about adding a dedicated pinctrl_hp for the headphone detect pin
> > like it is done at:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
> >
> kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fshawnguo%2Flinux.g
> it%2
> > Ftree%2Farch%2Farm64%2Fboot%2Fdts%2Ffreescale%2Fimx8mq-
> librem5.dtsi%3F
> > h%3Dfor-
> next%26id%3D8f0216b006e5f553d28c4c1a991b5234693a49cb%23n130&am
> >
> p;data=02%7C01%7Cshengjiu.wang%40nxp.com%7C672e70414ead4170b617
> 08d847c
> >
> 05117%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63733823860
> 3810133&
> >
> amp;sdata=69K7rVsYB35Iq%2FdE%2FSf2%2B862VlwOFRwSTYBML7OQxUE%3
> D&amp;res
> > erved=0
> >
> > My point is that we should avoid adding a hog group when possible.
> 
> I agree.  Hog group should be used as the last sort, when there is no clear
> client device owning the pins.
> 

Ok, thanks. I have sent v2.  That I refined three patches for this topic.

  ARM: dts: imx6sx-sdb: Add headphone detection for sound card
  ARM: dts: imx6sl-evk: Add headphone detection for sound card
  ARM: dts: imx6sll-evk: Add audio sound card node

Best regards
Wang shengjiu