linux-kernel - RE: [PATCH v2 02/19] dlb2: initialize PF device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SN6PR11MB2574E804F9AA4206A6B6AC2EF6560@SN6PR11MB2574.namprd11.prod.outlook.com>
Date:   Mon, 24 Aug 2020 16:50:58 +0000
From:   "Eads, Gage" <gage.eads@...el.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        "Topel, Bjorn" <bjorn.topel@...el.com>
Subject: RE: [PATCH v2 02/19] dlb2: initialize PF device

> > +#include <linux/io.h>
> > +
> > +#define DLB2_PCI_REG_READ(addr)        ioread32(addr)
> > +#define DLB2_PCI_REG_WRITE(reg, value) iowrite32(value, reg)
> 
> Why create a macro that is larger than the native call, this saves
> nothing except make the reviewer wonder what in the world is happening.
> 
> Just use the real call.

Sure, I'll change this in v3. I'll wait for more reviews before re-submitting.

Thanks,
Gage