linux-kernel - RE: [PATCH v7 10/10] Drivers: hv: Enable Hyper-V code to be built on ARM64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW2PR2101MB1052425768531AC236A34A9AD7560@MW2PR2101MB1052.namprd21.prod.outlook.com>
Date:   Mon, 24 Aug 2020 17:28:49 +0000
From:   Michael Kelley <mikelley@...rosoft.com>
To:     Ard Biesheuvel <ardb@...nel.org>
CC:     Will Deacon <will@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Catalin Marinas <catalin.marinas@....com>,
        "Mark.Rutland@....com" <Mark.Rutland@....com>,
        Marc Zyngier <maz@...nel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        linux-efi <linux-efi@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        vkuznets <vkuznets@...hat.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Sunil Muthuswamy <sunilmut@...rosoft.com>,
        Boqun Feng <boqun.feng@...il.com>
Subject: RE: [PATCH v7 10/10] Drivers: hv: Enable Hyper-V code to be built on
 ARM64

From: Ard Biesheuvel <ardb@...nel.org> Sent: Monday, August 24, 2020 10:24 AM
> 
> On Mon, 24 Aug 2020 at 18:48, Michael Kelley <mikelley@...rosoft.com> wrote:
> >
> > Update drivers/hv/Kconfig so CONFIG_HYPERV can be selected on
> > ARM64, causing the Hyper-V specific code to be built.
> >
> > Signed-off-by: Michael Kelley <mikelley@...rosoft.com>
> > ---
> >  drivers/hv/Kconfig | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig
> > index 79e5356..1113e49 100644
> > --- a/drivers/hv/Kconfig
> > +++ b/drivers/hv/Kconfig
> > @@ -4,7 +4,8 @@ menu "Microsoft Hyper-V guest support"
> >
> >  config HYPERV
> >         tristate "Microsoft Hyper-V client drivers"
> > -       depends on X86 && ACPI && X86_LOCAL_APIC && HYPERVISOR_GUEST
> > +       depends on ACPI && \
> > +                       ((X86 && X86_LOCAL_APIC && HYPERVISOR_GUEST) || ARM64)
> >         select PARAVIRT
> >         select X86_HV_CALLBACK_VECTOR
> >         help
> 
> Given the comment in a previous patch
> 
> +/*
> + * All data structures defined in the TLFS that are shared between Hyper-V
> + * and a guest VM use Little Endian byte ordering.  This matches the default
> + * byte ordering of Linux running on ARM64, so no special handling is required.
> + */
> 
> shouldn't this depend on !CONFIG_CPU_BIG_ENDIAN ?

Yes indeed.  I'll add it.

Michael