linux-kernel - Re: [PATCH v3] firmware_loader: fix memory leak for paged buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200824082147.GB336539@kroah.com>
Date:   Mon, 24 Aug 2020 10:21:47 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     Prateek Sood <prsood@...eaurora.org>, mcgrof@...nel.org,
        rafael@...nel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH v3] firmware_loader: fix memory leak for paged buffer

On Mon, Aug 24, 2020 at 10:19:50AM +0200, Takashi Iwai wrote:
> On Thu, 20 Aug 2020 22:57:50 +0200,
> Prateek Sood wrote:
> > 
> > vfree() is being called on paged buffer allocated
> > using alloc_page() and mapped using vmap().
> > 
> > Freeing of pages in vfree() relies on nr_pages of
> > struct vm_struct. vmap() does not update nr_pages.
> > It can lead to memory leaks.
> > 
> > Fixes: ddaf29fd9bb6 ("firmware: Free temporary page table after vmapping")
> > Signed-off-by: Prateek Sood <prsood@...eaurora.org>
> > Reviewed-by: Takashi Iwai <tiwai@...e.de>
> > Cc: stable@...r.kernel.org
> 
> Greg, could you review and merge this one please?

It's in my to-review queue, thanks.

greg k-h