linux-kernel - Re: [PATCH] net: Check the expect of skb->data at mac header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200824.154902.1388669182717688782.davem@davemloft.net>
Date:   Mon, 24 Aug 2020 15:49:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     linmiaohe@...wei.com
Cc:     kuba@...nel.org, martin.varghese@...ia.com, pshelar@....org,
        fw@...len.de, dcaratti@...hat.com, edumazet@...gle.com,
        steffen.klassert@...unet.com, pabeni@...hat.com,
        shmulik@...anetworks.com, kyk.segfault@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: Check the expect of skb->data at mac header

From: Miaohe Lin <linmiaohe@...wei.com>
Date: Thu, 20 Aug 2020 08:28:22 -0400

> skb_mpls_push() and skb_mpls_pop() expect skb->data at mac header. Check
> this assumption or we would get wrong mac_header and network_header.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Both openvswitch and act_mpls.c seem to adhere to this constraint.

I don't see real value to these extra checks, sorry.