linux-kernel - Re: [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200825090054.3c5dd68a@canb.auug.org.au>
Date:   Tue, 25 Aug 2020 09:00:54 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Michal Hocko <mhocko@...e.com>
Cc:     Qian Cai <cai@....pw>, Alex Shi <alex.shi@...ux.alibaba.com>,
        akpm@...ux-foundation.org, Johannes Weiner <hannes@...xchg.org>,
        Vladimir Davydov <vdavydov.dev@...il.com>,
        cgroups@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, linux-next@...r.kernel.org
Subject: Re: [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead
 page charged

Hi Michal,

On Mon, 24 Aug 2020 17:10:45 +0200 Michal Hocko <mhocko@...e.com> wrote:
>
> On Mon 24-08-20 10:52:02, Qian Cai wrote:
> > On Thu, Aug 20, 2020 at 10:58:50AM -0400, Qian Cai wrote:  
> > > On Tue, Aug 11, 2020 at 07:10:27PM +0800, Alex Shi wrote:  
> > > > Since readahead page is charged on memcg too, in theory we don't have to
> > > > check this exception now. Before safely remove them all, add a warning
> > > > for the unexpected !memcg.
> > > > 
> > > > Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com>
> > > > Acked-by: Michal Hocko <mhocko@...e.com>  
> > > 
> > > This will trigger,  
> > 
> > Andrew, Stephen, can you drop this series for now? I did manage to trigger this
> > warning on all arches, powerpc, x86 and arm64 (below).  
> 
> Yes, I do agree. See http://lkml.kernel.org/r/20200824151013.GB3415@dhcp22.suse.cz

OK, I have removed the following from linux-next for today:

  c443db77c9f3 ("mm/thp: narrow lru locking")
  18bafefba73d ("mm/thp: remove code path which never got into")
  5fb6c0683017 ("mm/thp: clean up lru_add_page_tail")
  9d1d568727a8 ("mm/thp: move lru_add_page_tail func to huge_memory.c")
  47eb331560ff ("mm/memcg: bail out early from swap accounting when memcg is disabled")
  4b0d99a64d78 ("mm/memcg: warning on !memcg after readahead page charged")

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped