linux-kernel - Re: [PATCH v2] scsi: ufs: Remove an unpaired ufshcd_scsi_unblock_requests() in err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Aug 2020 10:41:50 +0200
From:   Bean Huo <huobean@...il.com>
To:     Can Guo <cang@...eaurora.org>, asutoshd@...eaurora.org,
        nguyenb@...eaurora.org, hongwus@...eaurora.org,
        rnayak@...eaurora.org, linux-scsi@...r.kernel.org,
        kernel-team@...roid.com, saravanak@...gle.com, salyzyn@...gle.com
Cc:     Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Stanley Chu <stanley.chu@...iatek.com>,
        Bean Huo <beanhuo@...ron.com>,
        Bart Van Assche <bvanassche@....org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] scsi: ufs: Remove an unpaired
 ufshcd_scsi_unblock_requests() in err_handler()

On Tue, 2020-08-18 at 18:02 -0700, Can Guo wrote:
> Commit 5586dd8ea250 ("scsi: ufs: Fix a race condition between error
> handler
> and runtime PM ops") moves the ufshcd_scsi_block_requests() inside
> err_handler(), but forgets to remove the
> ufshcd_scsi_unblock_requests() in
> the early return path. Correct the coding mistake.
> 
> Fixes: 5586dd8ea250 ("scsi: ufs: Fix a race condition between error
> handler and runtime PM ops")
> Signed-off-by: Can Guo <cang@...eaurora.org>
> Reviewed-by: Asutosh Das <asutoshd@...eaurora.org>
> Reviewed-by: Hongwu Su<hongwus@...eaurora.org>

Reviewed-by: Bean Huo <beanhuo@...ron.com>