linux-kernel - Re: [net v2 PATCH 2/2] net: ethernet: ti: cpsw_new: fix clean up of vlan mc entries for host port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cca548db-7da2-7aa4-660c-bc3d22d3e023@ti.com>
Date:   Mon, 24 Aug 2020 07:09:57 -0400
From:   Murali Karicheri <m-karicheri2@...com>
To:     Jesse Brandeburg <jesse.brandeburg@...el.com>
CC:     <davem@...emloft.net>, <kuba@...nel.org>,
        <grygorii.strashko@...com>, <nsekhar@...com>,
        <linux-omap@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [net v2 PATCH 2/2] net: ethernet: ti: cpsw_new: fix clean up of
 vlan mc entries for host port



On 8/21/20 4:00 PM, Jesse Brandeburg wrote:
> Murali Karicheri wrote:
> 
>> To flush the vid + mc entries from ALE, which is required when a VLAN
>> interface is removed, driver needs to call cpsw_ale_flush_multicast()
>> with ALE_PORT_HOST for port mask as these entries are added only for
>> host port. Without this, these entries remain in the ALE table even
>> after removing the VLAN interface. cpsw_ale_flush_multicast() calls
>> cpsw_ale_flush_mcast which expects a port mask to do the job.
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@...com>
> 
> Patch looks good but please resend with a Fixes: tag.
> 
Sure will do
-- 
Murali Karicheri
Texas Instruments