lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Aug 2020 17:23:09 +0200 From: Kévin L'hôpital <kevin.lhopital@...tlin.com> To: Maxime Ripard <maxime@...no.tech> Cc: linux-media@...r.kernel.org, mchehab@...nel.org, robh+dt@...nel.org, mark.rutland@....com, wens@...e.org, yong.deng@...ewell.com, p.zabel@...gutronix.de, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, paul.kocialkowski@...tlin.com, thomas.petazzoni@...tlin.com Subject: Re: [PATCH 1/7] media: sun6i-csi: Fix the bpp for 10-bit bayer formats Hello, Le Mon, 24 Aug 2020 18:55:36 +0200, Maxime Ripard <maxime@...no.tech> a écrit : > On Fri, Aug 21, 2020 at 04:59:29PM +0200, Kévin L'hôpital wrote: > > 10-bit bayer formats are aligned to 16 bits in memory, so this is > > what needs to be used as bpp for calculating the size of the > > buffers to allocate. > > > > Signed-off-by: Kévin L'hôpital <kevin.lhopital@...tlin.com> > > Generally speaking, you should also explain why it's not an issue for > the callers. Depending on what that function is supposed to be doing > (returning the padded bits or the padded bits per pixel), your patch > could be either right or wrong. > > Since all the callers are using it to generate the number of bytes per > line, your patch is indeed correct. But it should be mentionned in the > commit log. > > Maxime All right, I will add this explanation. Thank you very much for the review Kévin -- Kevin L'Hopital, Bootlin Embedded Linux and kernel engineering https://bootlin.com
Powered by blists - more mailing lists