lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Aug 2020 17:32:36 +0200 From: Petr Mladek <pmladek@...e.com> To: David Laight <David.Laight@...lab.com> Cc: John Ogness <john.ogness@...utronix.de>, Linus Torvalds <torvalds@...ux-foundation.org>, Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>, Steven Rostedt <rostedt@...dmis.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Thomas Gleixner <tglx@...utronix.de>, Sergey Senozhatsky <sergey.senozhatsky@...il.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [RFC PATCH 1/5] printk: implement pr_cont_t On Tue 2020-08-25 13:38:57, David Laight wrote: > From: Petr Mladek > > Sent: 25 August 2020 14:11 > > > > On Thu 2020-08-20 12:33:23, David Laight wrote: > > > From: Petr Mladek > > > > Sent: 20 August 2020 11:16 > > > ... > > > > Now that I think about it. This is the biggest problem with any temporary buffer > > > > for pr_cont() lines. I am more and more convinced that we should just > > > > _keep the current behavior_. It is not ideal. But sometimes mixed > > > > messages are always better than lost ones. > > > > > > Maybe a marker to say 'more expected' might be useful. > > > OTOH lack of a trailing '\n' probably signifies that a > > > pr_cont() is likely to be next. > > > > The problem is the "probably". Lack of trailing '\n' might also mean > > that the author did not care. Note that newline is not strictly > > required at the moment. The next message is concatenated only when > > pr_cont() is used from the same process. > > Thinks.... (smoke comes out of ears...): > If the 'trace entry' contained the pid and whether it was a pr_cont > then the trace reader could merge continuation lines even if > there was a small number of interleaved other traces. > > So anything reading continuously might break a continuation > (as might happen if there is a trace from an ISR). > But the output from dmesg and /var/log/messages will > almost always be correct. > > This moves all the complexity away from the trace writing code. Yeah, this was the original plan. Unfortunately, it would require changes on the reader side and it would break existing readers (userspace), see https://lore.kernel.org/lkml/20200811160551.GC12903@alley/ And it is not acceptable, see https://lore.kernel.org/lkml/CAHk-=wivdy6-i=iqJ1ZG9YrRzaS0_LHHEPwb9KJg-S8i-Wm30w@mail.gmail.com/ Best Regards, Petr
Powered by blists - more mailing lists