[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200825174215.GA999117@bogus>
Date: Tue, 25 Aug 2020 11:42:15 -0600
From: Rob Herring <robh@...nel.org>
To: Crystal Guo <crystal.guo@...iatek.com>
Cc: p.zabel@...gutronix.de, matthias.bgg@...il.com,
srv_heupstream@...iatek.com, linux-mediatek@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, s-anna@...com, afd@...com,
seiya.wang@...iatek.com, stanley.chu@...iatek.com,
yingjoe.chen@...iatek.com, fan.chen@...iatek.com,
yong.liang@...iatek.com
Subject: Re: [v4,1/4] dt-binding: reset-controller: ti: add reset-duration-us
property
On Mon, Aug 17, 2020 at 11:03:21AM +0800, Crystal Guo wrote:
> introduce 'reset' method to allow device do serialized assert and
> deassert operations in a single step, which needs a minimum delay
> to be waited between assert and deassert.
Why is Mediatek adding to a TI binding?
>
> Signed-off-by: Crystal Guo <crystal.guo@...iatek.com>
> ---
> Documentation/devicetree/bindings/reset/ti-syscon-reset.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> index 86945502ccb5..ab041032339b 100644
> --- a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> +++ b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> @@ -59,6 +59,11 @@ Required properties:
> Please also refer to Documentation/devicetree/bindings/reset/reset.txt for
> common reset controller usage by consumers.
>
> +Optional properties:
> +- reset-duration-us: When do serialized assert and deassert operations, minimum delay in microseconds
> +is needed to be waited between an assert and a deassert to reset the device. This value can be 0, 0 means
> +that such a delay is not needed.
This goes in the reset controller node or each consumer? For the latter,
it should be a cell in 'resets' if you need this. But really, I think
the reset controller should enforce some minimum time that works for all
consumers. Surely having a minimum time per reset isn't really needed.
Rob
Powered by blists - more mailing lists