lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Aug 2020 11:04:16 -0700 (PDT) From: Palmer Dabbelt <palmer@...belt.com> To: Atish Patra <Atish.Patra@....com> CC: linux-kernel@...r.kernel.org, Atish Patra <Atish.Patra@....com>, Alistair Francis <Alistair.Francis@....com>, Anup Patel <Anup.Patel@....com>, ardb@...nel.org, nivedita@...m.mit.edu, Damien Le Moal <Damien.LeMoal@....com>, greentime.hu@...ive.com, hca@...ux.ibm.com, mingo@...nel.org, keescook@...omium.org, linux-efi@...r.kernel.org, linux-riscv@...ts.infradead.org, masahiroy@...nel.org, michal.simek@...inx.com, rppt@...nel.org, Nick Desaulniers <ndesaulniers@...gle.com>, Paul Walmsley <paul.walmsley@...ive.com>, steven.price@....com, longman@...hat.com, zong.li@...ive.com, daniel.schaefer@....com, abner.chang@....com Subject: Re: [PATCH v6 0/9] Add UEFI support for RISC-V On Wed, 19 Aug 2020 15:24:16 PDT (-0700), Atish Patra wrote: > This series adds UEFI support for RISC-V. > > Linux kernel: v5.9-rc1 > U-Boot: v2020.07 > OpenSBI: master > > Patch 1-3 are generic riscv feature addition required for UEFI support. > Patch 4-7 adds the efi stub support for RISC-V which was reviewed few months back. > https://www.spinics.net/lists/linux-efi/msg19144.html > Patch 8 just renames arm-init code so that it can be used across different > architectures. > Patch 9 adds the runtime services for RISC-V. > > The working set of patches can also be found in following git repo. > https://github.com/atishp04/linux/tree/uefi_riscv_5.10_v6 > > The patches have been verified on following platforms: > 1. Qemu (both RV32 & RV64) for the following bootflow > OpenSBI->U-Boot->Linux > EDK2->Linux > 2. HiFive unleashed using (RV64) for the following bootflow > OpenSBI->U-Boot->Linux > EDK2->Linux > > Thanks Abner & Daniel for all work done for EDK2. > The EDK2 instructions are available here. > https://github.com/JohnAZoidberg/riscv-edk2-docker/ > > Note: > 1. Currently, EDK2 RISC-V port doesn't support OVMF package. That's why > EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER should be enabled to load initrd via > commandline until OVMF patches are available. > > 2. For RV32, maximum allocated memory should be 1G as RISC-V kernel can not map > beyond 1G of physical memory for RV32. > > 3. Runtime services have been verified with fwts on EDK2. > > *********************************************************************** > [root@...ora-riscv ~]# fwts uefirtvariable > Running 1 tests, results appended to results.log > Test: UEFI Runtime service variable interface tests. > Test UEFI RT service get variable interface. 1 passed > Test UEFI RT service get next variable name interface. 4 passed > Test UEFI RT service set variable interface. 7 passed, 1 warning > Test UEFI RT service query variable info interface. 1 passed > Test UEFI RT service variable interface stress test. 2 passed > Test UEFI RT service set variable interface stress t.. 4 passed > Test UEFI RT service query variable info interface s.. 1 passed > Test UEFI RT service get variable interface, invalid.. 5 passed > Test UEFI RT variable services supported status. 1 skipped > > Test |Pass |Fail |Abort|Warn |Skip |Info | > uefirtvariable | 25| | | 1| 1| | > Total: | 25| 0| 0| 1| 1| 0| > > *********************************************************************** > > Changes from v5->v6: > 1. Fixed the static declaration for pt_ops. > 2. Added Reviewed/Acked-by. > > Changes from v4->v5: > 1. Late mappings allocations are now done through function pointers. > 2. EFI run time services are verified using full linux boot and fwts using EDK2. > > Changes from v3->v4: > 1. Used pgd mapping to avoid copying DT to bss. > > Changes from v2->v3: > 1. Fixed few bugs in run time services page table mapping. > 2. Dropped patch 1 as it is already taken into efi-tree. > 3. Sent few generic mmu fixes as a separate series to ease the merge conflicts. > > Changes from v1->v2: > 1. Removed patch 1 as it is already taken into efi-tree. > 2. Fixed compilation issues with patch 9. > 3. Moved few function prototype declaration to header file to keep kbuild happy. > > Changes from previous version: > 1. Added full ioremap support. > 2. Added efi runtime services support. > 3. Fixes mm issues > > Anup Patel (1): > RISC-V: Move DT mapping outof fixmap > > Atish Patra (8): > RISC-V: Add early ioremap support > RISC-V: Implement late mapping page table allocation functions > include: pe.h: Add RISC-V related PE definition > RISC-V: Add PE/COFF header for EFI stub > RISC-V: Add EFI stub support. > efi: Rename arm-init to efi-init common for all arch > RISC-V: Add EFI runtime services > RISC-V: Add page table dump support for uefi > > arch/riscv/Kconfig | 25 +++ > arch/riscv/Makefile | 1 + > arch/riscv/configs/defconfig | 1 + > arch/riscv/include/asm/Kbuild | 1 + > arch/riscv/include/asm/efi.h | 56 +++++ > arch/riscv/include/asm/fixmap.h | 16 +- > arch/riscv/include/asm/io.h | 1 + > arch/riscv/include/asm/mmu.h | 2 + > arch/riscv/include/asm/pgtable.h | 5 + > arch/riscv/include/asm/sections.h | 13 ++ > arch/riscv/kernel/Makefile | 5 + > arch/riscv/kernel/efi-header.S | 104 ++++++++++ > arch/riscv/kernel/efi.c | 105 ++++++++++ > arch/riscv/kernel/head.S | 17 +- > arch/riscv/kernel/head.h | 2 - > arch/riscv/kernel/image-vars.h | 51 +++++ > arch/riscv/kernel/setup.c | 17 +- > arch/riscv/kernel/vmlinux.lds.S | 22 +- > arch/riscv/mm/init.c | 191 +++++++++++++----- > arch/riscv/mm/ptdump.c | 48 ++++- > drivers/firmware/efi/Kconfig | 3 +- > drivers/firmware/efi/Makefile | 4 +- > .../firmware/efi/{arm-init.c => efi-init.c} | 0 > drivers/firmware/efi/libstub/Makefile | 10 + > drivers/firmware/efi/libstub/efi-stub.c | 11 +- > drivers/firmware/efi/libstub/riscv-stub.c | 110 ++++++++++ > drivers/firmware/efi/riscv-runtime.c | 143 +++++++++++++ > include/linux/pe.h | 3 + > 28 files changed, 900 insertions(+), 67 deletions(-) > create mode 100644 arch/riscv/include/asm/efi.h > create mode 100644 arch/riscv/include/asm/sections.h > create mode 100644 arch/riscv/kernel/efi-header.S > create mode 100644 arch/riscv/kernel/efi.c > create mode 100644 arch/riscv/kernel/image-vars.h > rename drivers/firmware/efi/{arm-init.c => efi-init.c} (100%) > create mode 100644 drivers/firmware/efi/libstub/riscv-stub.c > create mode 100644 drivers/firmware/efi/riscv-runtime.c I've put these on for-next. It's still pretty early in the cycle so there's some time to fix stuff up, but it looks like we've pretty much come to consensus on this. Thanks!
Powered by blists - more mailing lists