lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Aug 2020 23:11:56 +0200 From: Thomas Gleixner <tglx@...utronix.de> To: Bjorn Helgaas <helgaas@...nel.org> Cc: LKML <linux-kernel@...r.kernel.org>, x86@...nel.org, linux-pci@...r.kernel.org, Joerg Roedel <joro@...tes.org>, iommu@...ts.linux-foundation.org, linux-hyperv@...r.kernel.org, Haiyang Zhang <haiyangz@...rosoft.com>, Jon Derrick <jonathan.derrick@...el.com>, Lu Baolu <baolu.lu@...ux.intel.com>, Wei Liu <wei.liu@...nel.org>, "K. Y. Srinivasan" <kys@...rosoft.com>, Stephen Hemminger <sthemmin@...rosoft.com>, Steve Wahl <steve.wahl@....com>, Dimitri Sivanich <sivanich@....com>, Russ Anderson <rja@....com>, Bjorn Helgaas <bhelgaas@...gle.com>, Lorenzo Pieralisi <lorenzo.pieralisi@....com>, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>, xen-devel@...ts.xenproject.org, Juergen Gross <jgross@...e.com>, Boris Ostrovsky <boris.ostrovsky@...cle.com>, Stefano Stabellini <sstabellini@...nel.org>, Marc Zyngier <maz@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, Megha Dey <megha.dey@...el.com>, Jason Gunthorpe <jgg@...lanox.com>, Dave Jiang <dave.jiang@...el.com>, Alex Williamson <alex.williamson@...hat.com>, Jacob Pan <jacob.jun.pan@...el.com>, Baolu Lu <baolu.lu@...el.com>, Kevin Tian <kevin.tian@...el.com>, Dan Williams <dan.j.williams@...el.com> Subject: Re: [patch RFC 13/38] PCI: MSI: Rework pci_msi_domain_calc_hwirq() On Tue, Aug 25 2020 at 15:03, Bjorn Helgaas wrote: > On Fri, Aug 21, 2020 at 02:24:37AM +0200, Thomas Gleixner wrote: >> Retrieve the PCI device from the msi descriptor instead of doing so at the >> call sites. > > I'd like it *better* with "PCI/MSI: " in the subject (to match history Duh, yes. > and other patches in this series) and "MSI" here in the commit log, > but nice cleanup and: >> --- a/arch/x86/kernel/apic/msi.c >> +++ b/arch/x86/kernel/apic/msi.c >> @@ -232,7 +232,7 @@ EXPORT_SYMBOL_GPL(pci_msi_prepare); >> >> void pci_msi_set_desc(msi_alloc_info_t *arg, struct msi_desc *desc) >> { >> - arg->msi_hwirq = pci_msi_domain_calc_hwirq(arg->msi_dev, desc); >> + arg->msi_hwirq = pci_msi_domain_calc_hwirq(desc); > > I guess it's safe to assume that "arg->msi_dev == > msi_desc_to_pci_dev(desc)"? I didn't try to verify that. It is. >> +irq_hw_number_t pci_msi_domain_calc_hwirq(struct msi_desc *desc) >> { >> + struct pci_dev *pdev = msi_desc_to_pci_dev(desc); > > If you named this "struct pci_dev *dev" (not "pdev"), the diff would > be a little smaller and it would match other usage in the file. Ok. I'm always happy to see pdev because that doesn't make me wonder which type of dev it is :) But, yeah lets keep it consistent. Thanks, tglx
Powered by blists - more mailing lists