lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Aug 2020 17:08:55 -0500 From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com> To: Mark Brown <broonie@...nel.org> Cc: alsa-devel@...a-project.org, linux-kernel@...r.kernel.org, tiwai@...e.de, vkoul@...nel.org, gregkh@...uxfoundation.org, jank@...ence.com, srinivas.kandagatla@...aro.org, slawomir.blauciak@...el.com, Bard liao <yung-chuan.liao@...ux.intel.com>, Rander Wang <rander.wang@...ux.intel.com>, Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>, Hui Wang <hui.wang@...onical.com>, Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>, Kai Vehmanen <kai.vehmanen@...ux.intel.com>, "Rafael J. Wysocki" <rafael@...nel.org> Subject: Re: [PATCH 1/4] regmap: sdw: move to -EOPNOTSUPP >> -ENOTSUPP is not a valid error code, use recommended value instead. > > What makes you say this - it's what regmap uses internally for > unsupported operations? This was flagged by scripts/checkpatch.pl (must be a new addition). # ENOTSUPP is not a standard error code and should be avoided in new patches. # Folks usually mean EOPNOTSUPP (also called ENOTSUP), when they type ENOTSUPP. # Similarly to ENOSYS warning a small number of false positives is expected. if (!$file && $line =~ /\bENOTSUPP\b/) { if (WARN("ENOTSUPP", "ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP\n" . $herecurr) && $fix) { $fixed[$fixlinenr] =~ s/\bENOTSUPP\b/EOPNOTSUPP/; } } I was just blindly making checkpatch happy and tried to keep regmap-sdw.c and regmap-sdw-mbq aligned.
Powered by blists - more mailing lists