linux-kernel - Re: [PATCH] scsi: megaraid: Remove unnecessary assignment to variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dc8aca7e3772670782c2abc086cab8b6f81be3c1.camel@perches.com>
Date:   Tue, 25 Aug 2020 00:06:26 -0700
From:   Joe Perches <joe@...ches.com>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>,
        kashyap.desai@...adcom.com, sumit.saxena@...adcom.com,
        shivasharan.srikanteshwara@...adcom.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: megaraid: Remove unnecessary assignment to
 variable ret

On Tue, 2020-08-25 at 00:01 -0700, Joe Perches wrote:
> On Tue, 2020-08-25 at 14:38 +0800, Jing Xiangfeng wrote:
> > The variable ret is being initialized with 'FAILED'. So we can remove
> > this assignement.
> 
> If you are going to change the code at all,
> might as well try to improve it more by removing
> the unnecessary out: label altogether.

Looks like the megaraid mailing list is either subscribers-only
or doesn't exist anymore as my mail to it bounced.

One of the maintainers should remove it or update it.

Maybe:
---
diff --git a/MAINTAINERS b/MAINTAINERS
index ac79fdbdf8d0..0c181cd07201 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11060,7 +11060,7 @@ MEGARAID SCSI/SAS DRIVERS
 M:	Kashyap Desai <kashyap.desai@...adcom.com>
 M:	Sumit Saxena <sumit.saxena@...adcom.com>
 M:	Shivasharan S <shivasharan.srikanteshwara@...adcom.com>
-L:	megaraidlinux.pdl@...adcom.com
+L:	megaraidlinux.pdl@...adcom.com (subscribers-only)
 L:	linux-scsi@...r.kernel.org
 S:	Maintained
 W:	http://www.avagotech.com/support/