lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Aug 2020 09:47:56 +0200 From: Mathieu Malaterre <malat@...ian.org> To: Dinghao Liu <dinghao.liu@....edu.cn> Cc: kjlu@....edu, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Linux Fbdev development list <linux-fbdev@...r.kernel.org>, dri-devel <dri-devel@...ts.freedesktop.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] video: fbdev: radeon: Fix memleak in radeonfb_pci_register On Tue, Aug 25, 2020 at 9:27 AM Dinghao Liu <dinghao.liu@....edu.cn> wrote: > > When radeon_kick_out_firmware_fb() fails, info should be > freed just like the subsequent error paths. > > Fixes: 069ee21a82344 ("fbdev: Fix loading of module radeonfb on PowerMac") > Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn> > --- > drivers/video/fbdev/aty/radeon_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c > index 3fe509cb9b87..13bd2bd5c043 100644 > --- a/drivers/video/fbdev/aty/radeon_base.c > +++ b/drivers/video/fbdev/aty/radeon_base.c > @@ -2307,7 +2307,7 @@ static int radeonfb_pci_register(struct pci_dev *pdev, > > ret = radeon_kick_out_firmware_fb(pdev); > if (ret) > - return ret; > + goto err_release_fb; Good catch ! Thanks Reviewed-by: Mathieu Malaterre <malat@...ian.org> > /* request the mem regions */ > ret = pci_request_region(pdev, 0, "radeonfb framebuffer"); > -- > 2.17.1 >
Powered by blists - more mailing lists