linux-kernel - Re: [PATCH v2 17/19] dt-bindings: serial: fsl-lpuart: Fix compatible matching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200825075543.GA10369@kozik-lap>
Date:   Tue, 25 Aug 2020 09:55:43 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Will Deacon <will@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Thierry Reding <thierry.reding@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Guenter Roeck <linux@...ck-us.net>,
        Li Yang <leoyang.li@....com>, Han Xu <han.xu@....com>,
        Frank Li <frank.li@....com>, Fugang Duan <fugang.duan@....com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mmc@...r.kernel.org, linux-mtd@...ts.infradead.org,
        linux-pwm@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH v2 17/19] dt-bindings: serial: fsl-lpuart: Fix compatible
 matching

On Mon, Aug 24, 2020 at 08:42:26PM -0600, Rob Herring wrote:
> On Mon, Aug 24, 2020 at 06:26:50PM +0200, Krzysztof Kozlowski wrote:
> > The i.MX 8QXP DTSes use two compatibles so update the binding to fix
> > dtbs_check warnings like:
> > 
> >   arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml: serial@...60000:
> >     compatible: ['fsl,imx8qxp-lpuart', 'fsl,imx7ulp-lpuart'] is too long
> >     From schema: Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > 
> >   arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml: serial@...60000:
> >     compatible: Additional items are not allowed ('fsl,imx7ulp-lpuart' was unexpected)
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> > 
> > ---
> > 
> > Changes since v1:
> > 1. New patch.
> > ---
> >  .../devicetree/bindings/serial/fsl-lpuart.yaml | 18 +++++++++++-------
> >  1 file changed, 11 insertions(+), 7 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > index e82c2cf9fef7..8ee651f2ef0b 100644
> > --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > @@ -14,13 +14,17 @@ allOf:
> >  
> >  properties:
> >    compatible:
> > -    enum:
> > -      - fsl,vf610-lpuart
> > -      - fsl,ls1021a-lpuart
> > -      - fsl,ls1028a-lpuart
> > -      - fsl,imx7ulp-lpuart
> > -      - fsl,imx8qxp-lpuart
> > -      - fsl,imx8qm-lpuart
> > +    oneOf:
> > +      - enum:
> > +          - fsl,vf610-lpuart
> > +          - fsl,ls1021a-lpuart
> > +          - fsl,ls1028a-lpuart
> > +          - fsl,imx7ulp-lpuart
> > +          - fsl,imx8qxp-lpuart
> 
> This should be dropped.

Right.

Best regards,
Krzysztof