linux-kernel - Re: [PATCH v2 2/2] leds: Add an optional property named 'sdb-gpios'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d0ae6853-94a7-ca4e-61f1-e5119efa41bf@163.com>
Date:   Tue, 25 Aug 2020 16:05:14 +0800
From:   Grant Feng <von81@....com>
To:     Rob Herring <robh@...nel.org>
Cc:     jacek.anaszewski@...il.com, pavel@....cz, dmurphy@...com,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] leds: Add an optional property named 'sdb-gpios'


On 2020-08-25 6:21, Rob Herring wrote:
> On Sat, Aug 08, 2020 at 11:37:31AM +0800, Grant Feng wrote:
>> The chip enters hardware shutdown when the SDB pin is pulled low.
>> The chip releases hardware shutdown when the SDB pin is pulled high.
>>
>> Signed-off-by: Grant Feng <von81@....com>
>> ---
>>   Documentation/devicetree/bindings/leds/leds-is31fl319x.txt | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-is31fl319x.txt b/Documentation/devicetree/bindings/leds/leds-is31fl319x.txt
>> index fc2603484544..e8bef4be57dc 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-is31fl319x.txt
>> +++ b/Documentation/devicetree/bindings/leds/leds-is31fl319x.txt
>> @@ -16,6 +16,7 @@ Optional properties:
>>   - audio-gain-db : audio gain selection for external analog modulation input.
>>   	Valid values: 0 - 21, step by 3 (rounded down)
>>   	Default: 0
>> +- sdb-gpios : Specifier of the GPIO connected to SDB pin.
> We normally use 'shutdown-gpios' for a shutdown GPIO.
Thanks for the review.
>>   
>>   Each led is represented as a sub-node of the issi,is31fl319x device.
>>   There can be less leds subnodes than the chip can support but not more.
>> @@ -44,6 +45,7 @@ fancy_leds: leds@65 {
>>   	#address-cells = <1>;
>>   	#size-cells = <0>;
>>   	reg = <0x65>;
>> +	sdb-gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>;
>>   
>>   	red_aux: led@1 {
>>   		label = "red:aux";
>> -- 
>> 2.17.1
>>
>>