linux-kernel - Re: [PATCH 1/1] MIPS: CI20: Update defconfig for EFUSE.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200825083508.GA13642@kozik-lap>
Date:   Tue, 25 Aug 2020 10:35:08 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     周琰杰 (Zhou Yanjie) 
        <zhouyanjie@...yeetech.com>
Cc:     tsbogend@...ha.franken.de, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        zhenwenjin@...il.com, sernia.zhou@...mail.com,
        yanfei.li@...enic.com, rick.tyliu@...enic.com,
        aric.pzqi@...enic.com, dongsheng.qiu@...enic.com,
        hns@...delico.com, ebiederm@...ssion.com, paul@...pouillou.net
Subject: Re: [PATCH 1/1] MIPS: CI20: Update defconfig for EFUSE.

On Tue, Aug 25, 2020 at 03:52:39PM +0800, 周琰杰 (Zhou Yanjie) wrote:
> The commit 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
> controller use NVMEM to find the default MAC address") add EFUSE
> node for DM9000 in CI20, however, the EFUSE driver is not selected,
> which will cause the DM9000 to fail to read the MAC address from
> EFUSE, causing the following issue:
> 
> [FAILED] Failed to start Raise network interfaces.
> 
> Fix this problem by select CONFIG_JZ4780_EFUSE by default in the
> ci20_defconfig.
> 
> Fixes: 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
> controller use NVMEM to find the default MAC address").

There is nothing to fix here or to backport to stable. The defconfigs
are just examples, useful for development and for downstream.

If you really think there is a bug which should be fixed, then there
should be dependency on JZ4780_EFUSE by Ethernet driver.

Best regards,
Krzysztof

> 
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>
> ---
>  arch/mips/configs/ci20_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci20_defconfig
> index 0a46199fdc3f..050ee6a17e11 100644
> --- a/arch/mips/configs/ci20_defconfig
> +++ b/arch/mips/configs/ci20_defconfig
> @@ -131,6 +131,7 @@ CONFIG_MEMORY=y
>  CONFIG_JZ4780_NEMC=y
>  CONFIG_PWM=y
>  CONFIG_PWM_JZ4740=m
> +CONFIG_JZ4780_EFUSE=y
>  CONFIG_EXT4_FS=y
>  # CONFIG_DNOTIFY is not set
>  CONFIG_PROC_KCORE=y
> -- 
> 2.11.0
>