lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Aug 2020 10:40:53 +0200 From: Krzysztof Kozlowski <krzk@...nel.org> To: "Ramuthevar,Vadivel MuruganX" <vadivel.muruganx.ramuthevar@...ux.intel.com> Cc: cw00.choi@...sung.com, linux-kernel@...r.kernel.org, vijaikumar.kanagarajan@...il.com, myungjoo.ham@...sung.com, cheol.yong.kim@...el.com, qi-ming.wu@...el.com, yin1.li@...el.com Subject: Re: [PATCH v1 1/1] extcon: ptn5150: Add usb-typec support for Intel LGM SoC On Tue, Aug 25, 2020 at 04:31:47PM +0800, Ramuthevar,Vadivel MuruganX wrote: > From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@...ux.intel.com> > > Add usb-typec detection support for Intel LGM SoC based > boards. > > Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@...ux.intel.com> > --- > drivers/extcon/extcon-ptn5150.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c > index 8ba706fad887..60355a1b5cb2 100644 > --- a/drivers/extcon/extcon-ptn5150.c > +++ b/drivers/extcon/extcon-ptn5150.c > @@ -300,6 +300,8 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c) > return ret; > } > > + extcon_set_property_capability(info->edev, EXTCON_USB_HOST, > + EXTCON_PROP_USB_TYPEC_POLARITY); Hi, I think you need the same for EXTCON_USB. Although extcon_set_property_capability() error should not be fatal, but printing a warn message would be useful. Best regards, Krzysztof > /* Initialize PTN5150 device and print vendor id and version id */ > ret = ptn5150_init_dev_type(info); > if (ret) > -- > 2.11.0 >
Powered by blists - more mailing lists