lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Aug 2020 19:01:01 +0530 From: Amit Pundir <amit.pundir@...aro.org> To: Konrad Dybcio <konradybcio@...il.com> Cc: Andy Gross <agross@...nel.org>, Bjorn Andersson <bjorn.andersson@...aro.org>, Rob Herring <robh+dt@...nel.org>, John Stultz <john.stultz@...aro.org>, Sumit Semwal <sumit.semwal@...aro.org>, linux-arm-msm <linux-arm-msm@...r.kernel.org>, dt <devicetree@...r.kernel.org>, lkml <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v5] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium) Hi Konrad, On Sat, 22 Aug 2020 at 02:51, Konrad Dybcio <konradybcio@...il.com> wrote: > > Hi > > First of all, sorry if anybody sees this twice. I've been messing with Thunderbird lately. > > > > > dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r3.dtb > > dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c.dtb > > +dtb-$(CONFIG_ARCH_QCOM) += sdm845-beryllium.dtb > > [B]eryllium should come before [C]heza, no? Also, aren't the non-development boards supposed to include the vendor name? i.e. sdm845-(xiaomi/poco)-beryllium.dtb Ack. I didn't pay attention to that part. I'll fix that. > > > > + model = "Xiaomi Technologies Inc. Beryllium"; > > At least with Xperias, we settled on setting the model property to the "pretty" name, in this case Poco F1 Ack. > > > > + pm8998-rpmh-regulators { > > + compatible = "qcom,pm8998-rpmh-regulators"; > > + qcom,pmic-id = "a"; > > + > > + vreg_l1a_0p875: ldo1 { > > I think you forgot to include (regulatorname)-supply properties which should cause havoc with all things regulators.. I didn't know that. Thanks for pointing that out. I just copied db845c dts and started removing the nodes/properties which I didn't seem fit. There is a very good probability that I goofed up big time. FWIW in my limited testing so far (Booted AOSP to UI, with working Touchscreen/BT/WiFi/Audio with out-of-tree drivers [1]), I didn't run into issues with mainline (v5.9-rc1) or Android GKI (v5.4.58). May be I just got lucky. I'll check up on the usage of (regulatorname)-supply properties. > > > > + vreg_l1a_0p875: ldo1 { > > + regulator-min-microvolt = <880000>; > > + regulator-max-microvolt = <880000>; > 0p88? Unless it's a PMIC limitation.. Please also confirm names for the rest of the regulators. > > Also why are there so few regulators? And none from pmi8998? Are the rest WIP/coming in a followup commit, or are they disabled on this board? AFAICS you only include SoC/PMIC DTs which would suggest they should be there. I intend to add more regulators and feature nodes in follow up commits. > > > > +/* Reserved memory changes from downstream */ > > Wouldn't it look better if you included that in the main {} node instead of reopening it in the middle of the file? I mean, it works, but let's hear what others have to say. Ack. I'll fix that if necessary. > > > > + * It seems that mmc_test reports errors if drive > > + * strength is not 16 on clk, cmd, and data pins. > > You say that, but then you set "drive-strength = <10>;" for cmd and data, please confirm it's intentional. In sync with db845c as well as downstream dts but I'll check on this as well. > > > > +&ufs_mem_hc { > > UFS comes before USB alphabetically. Ack. I'll add them alphabetically if that is the common norm. Regards, Amit Pundir [1] https://github.com/pundiramit/linux/commits/beryllium-mainline > > > > +&ufs_mem_phy > > Ditto > > > > +&qup_uart6_default > > Ditto > > > Konrad
Powered by blists - more mailing lists