linux-kernel - Re: [PATCH] drm/sun4i: add missing put_device() call in sun8i_r40_tcon_tv_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200825133851.scnipngfpm6jyje5@gilmour.lan>
Date:   Tue, 25 Aug 2020 15:38:51 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Yu Kuai <yukuai3@...wei.com>
Cc:     wens@...e.org, airlied@...ux.ie, daniel@...ll.ch,
        jernej.skrabec@...l.net, dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        yi.zhang@...wei.com
Subject: Re: [PATCH] drm/sun4i: add missing put_device() call in
 sun8i_r40_tcon_tv_set_mux()

Hi,

On Tue, Aug 25, 2020 at 07:44:03PM +0800, Yu Kuai wrote:
> If sun8i_r40_tcon_tv_set_mux() succeed, at_dma_xlate() doesn't have a
> corresponding put_device(). Thus add put_device() to fix the exception
> handling for this function implementation.
> 
> Fixes: 0305189afb32 ("drm/sun4i: tcon: Add support for R40 TCON")
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>

That doesn't sound right, we're not using at_dma_xlate at all in that
driver?

Maxime