lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Aug 2020 01:03:25 +0000 From: "Mani, Rajmohan" <rajmohan.mani@...el.com> To: Prashant Malani <pmalani@...omium.org> CC: Darren Hart <dvhart@...radead.org>, Andy Shevchenko <andy@...radead.org>, Mika Westerberg <mika.westerberg@...ux.intel.com>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Lee Jones <lee.jones@...aro.org>, Ayman Bagabas <ayman.bagabas@...il.com>, Masahiro Yamada <masahiroy@...nel.org>, "Joseph, Jithu" <jithu.joseph@...el.com>, Blaž Hrastnik <blaz@...n.io>, Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>, "bleung@...omium.org" <bleung@...omium.org> Subject: RE: [PATCH v2 1/3] platform/x86: Add Intel Input Output Manager (IOM) driver Hi Prashant, ... > > > > + > > > > + reg = iom->regbar + IOM_PORT_STATUS_OFFSET + IOM_REG_LEN * > > > port; > > > > + > > > > + *status = ioread32(reg); > > > > > > Perhaps just inline reg within the parentheses? > > > > Kept this way to increase readability. Let me know if you feel > > strongly towards inline reg. > > I'd rather this be inlined, you save a couple lines from the variable declaration, > and IMO we're not gaining much in terms of readability by declaring this > separately. > Ack (at least to me, it was more readable) ... > > > > > > + > > > > + return 0; > > > > +} > > > > +EXPORT_SYMBOL_GPL(intel_iom_port_status); > > > > + > > > > +static int intel_iom_probe(struct platform_device *pdev) { > > > > + void __iomem *addr; > > > > + > > > > + /* only one IOM device is supported */ > > > > > > Minor nit: s/only/Only > > > > And then I may need to end the comment with a period. > > Let me know if you feel strongly. > Yes, let's capitalize and add the period. Let's try to use the right punctuation > where possible. > Ack Will take care of this as part of v3.
Powered by blists - more mailing lists