linux-kernel - Re: [PATCH 2/3] software node: Introduce device_add_software

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200825143353.GL1891694@smile.fi.intel.com>
Date:   Tue, 25 Aug 2020 17:33:53 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Felipe Balbi <balbi@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-acpi@...r.kernel.org
Subject: Re: [PATCH 2/3] software node: Introduce device_add_software_node()

On Tue, Aug 25, 2020 at 05:32:28PM +0300, Andy Shevchenko wrote:
> On Tue, Aug 25, 2020 at 04:59:50PM +0300, Heikki Krogerus wrote:
> > This helper will register a software node and then assign
> > it to device at the same time. The function will also make
> > sure that the device can't have more than one software node.
> 
> > +	/* Only one software node per device. */
> > +	if (dev_to_swnode(dev))
> > +		return -EBUSY;
> 
> > +	swnode = dev_to_swnode(dev);
> > +	if (!swnode)
> > +		return;
> 
> Hmm... I didn't find implementation of dev_to_swnode().
> What did I miss?

Now found, I was looking into header, but it's defined in the c-file in
previous patch.

-- 
With Best Regards,
Andy Shevchenko