lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Aug 2020 02:06:05 +0100 From: Matthew Wilcox <willy@...radead.org> To: Dave Chinner <david@...morbit.com> Cc: linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org, "Darrick J . Wong" <darrick.wong@...cle.com>, linux-nvdimm@...ts.01.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 8/9] iomap: Convert iomap_write_end types On Tue, Aug 25, 2020 at 10:12:23AM +1000, Dave Chinner wrote: > > -static int > > -__iomap_write_end(struct inode *inode, loff_t pos, unsigned len, > > - unsigned copied, struct page *page) > > +static size_t __iomap_write_end(struct inode *inode, loff_t pos, size_t len, > > + size_t copied, struct page *page) > > { > > Please leave the function declarations formatted the same way as > they currently are. They are done that way intentionally so it is > easy to grep for function definitions. Not to mention is't much > easier to read than when the function name is commingled into the > multiline paramener list like... I understand that's true for XFS, but it's not true throughout the rest of the kernel. This file isn't even consistent: buffered-io.c:static inline struct iomap_page *to_iomap_page(struct page *page) buffered-io.c:static inline bool iomap_block_needs_zeroing(struct inode buffered-io.c:static int iomap_zero(struct inode *inode, loff_t pos, unsigned offset, buffered-io.c:static void iomap_writepage_end_bio(struct bio *bio) buffered-io.c:static int __init iomap_init(void) (i just grepped for ^static so there're other functions not covered by this) The other fs/iomap/ files are equally inconsistent.
Powered by blists - more mailing lists