linux-kernel - Re: [PATCH v2] kobject: Restore old behaviour of kobject

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200825144109.GN1891694@smile.fi.intel.com>
Date:   Tue, 25 Aug 2020 17:41:09 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Qu Wenruo <quwenruo.btrfs@....com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCH v2] kobject: Restore old behaviour of kobject_del(NULL)

On Mon, Aug 03, 2020 at 11:46:59AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 03, 2020 at 11:27:06AM +0300, Andy Shevchenko wrote:
> > The commit 079ad2fb4bf9 ("kobject: Avoid premature parent object freeing in
> > kobject_cleanup()") inadvertently dropped a possibility to call kobject_del()
> > with NULL pointer. Restore the old behaviour.
> > 
> > Fixes: 079ad2fb4bf9 ("kobject: Avoid premature parent object freeing in kobject_cleanup()")
> > Reported-by: Qu Wenruo <quwenruo.btrfs@....com>
> > Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > ---
> > v2: replaced ?: with plain conditional (Greg)
> >  lib/kobject.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> Thanks, much better, will queue up after -rc1 is out.

Shouldn't be this taken care of?

-- 
With Best Regards,
Andy Shevchenko