linux-kernel - Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <s5hk0xm4vk9.wl-tiwai@suse.de>
Date:   Tue, 25 Aug 2020 17:03:18 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Adrien Crivelli <adrien.crivelli@...il.com>
Cc:     Alex Dewar <alex.dewar90@...il.com>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches

On Tue, 25 Aug 2020 16:36:13 +0200,
Adrien Crivelli wrote:
> 
> [1  <text/plain; UTF-8 (7bit)>]
> 
> I believe the code is correct (even though the diff is confusing), but I can
> edit the commit message to also mention the model name.
> 
> Should I submit the patch here as a reply ? or should I create a brand new
> submission in a new thread ?

In a new thread please.


thanks,

Takashi

> 
> On Tue, 25 Aug 2020 at 17:00, Takashi Iwai <tiwai@...e.de> wrote:
> 
>     On Mon, 24 Aug 2020 14:31:17 +0200,
>     Alex Dewar wrote:
>     >
>     > My mistake -- I didn't read your changelog properly. Sorry!
>    
>     Would you resubmit the corrected fix patch?
>    
>     Also, better to indicate the device id number in the patch
>     description.  It's confusing which entry you've corrected
>     intentionally for what, and documenting it would help understanding
>     it.
> 
>     thanks,
>    
>     Takashi
>    
>     >
>     > On 24/08/2020 13:30, Alex Dewar wrote:
>     > > There's a mistake in this. The ID numbers are the wrong way round.
>     > >
>     > > Alex
>     >
> 
>