linux-kernel - Re: [PATCH v2 2/2] i2c: eg20t: use generic power management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200825151655.GA1913382@bjorn-Precision-5520>
Date:   Tue, 25 Aug 2020 10:16:55 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Jean Delvare <jdelvare@...e.de>
Cc:     Vaibhav Gupta <vaibhavgupta40@...il.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Vaibhav Gupta <vaibhav.varodek@...il.com>,
        Tomoya MORINAGA <tomoya-linux@....okisemi.com>,
        Tomoya MORINAGA <tomoya.rohm@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Ben Dooks <ben.dooks@...ethink.co.uk>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        Shuah Khan <skhan@...uxfoundation.org>,
        Jean Delvare <jdelvare@...e.com>
Subject: Re: [PATCH v2 2/2] i2c: eg20t: use generic power management

On Tue, Aug 25, 2020 at 11:53:42AM +0200, Jean Delvare wrote:
> Hi Bjorn, Vaibhav,
> 
> On Fri, 07 Aug 2020 15:23:21 -0500, Bjorn Helgaas wrote:
> > Also, i801_suspend() looks suspicious because it writes SMBHSTCFG, but
> > I don't see anything corresponding in i801_resume().
> 
> You're right, it's buggy. Volker Rümelin's patch at:
> 
> https://patchwork.ozlabs.org/project/linux-i2c/patch/a2fc5a6d-a3bf-eaf0-bb75-1521be346333@googlemail.com/
> 
> should fix it. I was supposed to review it but did not, shame on me.
> I'll do it today.

Always nice when the fix is already there :)  Thanks for following up
on this!

Bjorn