linux-kernel - Re: [PATCH 29/29] tools: Avoid comma separated statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1696974.unB1bf7olB@c100>
Date:   Wed, 26 Aug 2020 18:13:30 +0200
From:   Thomas Renninger <trenn@...e.com>
To:     Jiri Kosina <trivial@...nel.org>, linux-kernel@...r.kernel.org,
        Joe Perches <joe@...ches.com>
Cc:     Shuah Khan <shuah@...nel.org>, linux-pm@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 29/29] tools: Avoid comma separated statements

Am Mittwoch, 26. August 2020, 16:45:24 CEST schrieb Joe Perches:
> On Wed, 2020-08-26 at 11:30 +0200, Thomas Renninger wrote:
> > Hi,
> > 

> Read the block immediately below that too:
> 
> "This does not apply if only one branch of a conditional statement is a
> single statement; in the latter case use braces in both branches:"

Then +1 from here.

> > Afaik there isn't a specific tag, but having:
> > cleanup only: No functional change
> > 
> > in the changelog would be nice for people looking for fixes to backport.
> 
> This is not a fix, so it's not for backporting.

Mentioning that in the changelog explicitly or even in the title - cleanup 
only
is nice imho, but should definitely not be the reason for re-posting.

Thanks for doing this,

   Thomas