linux-kernel - Re: [PATCH v4 0/5] Fix ELF / FDPIC ELF core dumping, and use mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHk-=wgedMxgfNPccK9Fgm0JQ=UX91HCndOnO1qAiUOoCOJi5w@mail.gmail.com>
Date:   Wed, 26 Aug 2020 10:15:42 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Jann Horn <jannh@...gle.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Christoph Hellwig <hch@....de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux-MM <linux-mm@...ck.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        "Eric W . Biederman" <ebiederm@...ssion.com>,
        Oleg Nesterov <oleg@...hat.com>
Subject: Re: [PATCH v4 0/5] Fix ELF / FDPIC ELF core dumping, and use
 mmap_lock properly in there

On Wed, Aug 26, 2020 at 8:15 AM Jann Horn <jannh@...gle.com> wrote:
>
> After this series has landed, we should be able to rip out
> mmget_still_valid().

I think you should just add that to the series, since it's kind of the
point of it all.

But ack on this, it now looks saner than what we used to have regardless.

I do wonder if we should possibly just limit the number of vma's we
dump based on core size ulimit too, but that, I think, might be a
"further improvement" rather than base cleanup.

                 Linus