linux-kernel - [PATCH] kconfig: streamline_config.pl: check defined(ENV variable) before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <be80ceda-596b-03aa-394f-166cc6388aa0@infradead.org>
Date:   Wed, 26 Aug 2020 14:21:43 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-kbuild <linux-kbuild@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Masahiro Yamada <masahiroy@...nel.org>
Cc:     Changbin Du <changbin.du@...il.com>
Subject: [PATCH] kconfig: streamline_config.pl: check defined(ENV variable)
 before using it

From: Randy Dunlap <rdunlap@...radead.org>

A user reported:
'Use of uninitialized value $ENV{"LMC_KEEP"} in split at
 ./scripts/kconfig/streamline_config.pl line 596.'

so first check that $ENV{LMC_KEEP} is defined before trying
to use it.

Fixes: c027b02d89fd ("streamline_config.pl: add LMC_KEEP to preserve some kconfigs")
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Changbin Du <changbin.du@...il.com>
Cc: Steven Rostedt (VMware) <rostedt@...dmis.org>
Cc: Masahiro Yamada <masahiroy@...nel.org>
Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
---
 scripts/kconfig/streamline_config.pl |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

--- linux-next-20200825.orig/scripts/kconfig/streamline_config.pl
+++ linux-next-20200825/scripts/kconfig/streamline_config.pl
@@ -593,7 +593,10 @@ while ($repeat) {
 }
 
 my %setconfigs;
-my @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP});
+my @preserved_kconfigs;
+if (defined($ENV{'LMC_KEEP'})) {
+	@preserved_kconfigs = split(/:/,$ENV{LMC_KEEP});
+}
 
 sub in_preserved_kconfigs {
     my $kconfig = $config2kfile{$_[0]};