linux-kernel - RE: [PATCH] [v2] blk-mq: use BLK_MQ_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3321aa16ad214cb1a0a5cda1309f0e45@h3c.com>
Date:   Wed, 26 Aug 2020 06:02:57 +0000
From:   Tianxianting <tian.xianting@....com>
To:     Ming Lei <ming.lei@...hat.com>
CC:     "axboe@...nel.dk" <axboe@...nel.dk>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] [v2] blk-mq: use BLK_MQ_NO_TAG for no tag

Hi Ming Lei
Thanks for your quick comment.
As the function request_to_qc_t() in 'include/linux/blk-mq.h ' used the magic '-1',
Seems it is hard to replace it with BLK_MQ_NO_TAG :(

-----Original Message-----
From: Ming Lei [mailto:ming.lei@...hat.com] 
Sent: Wednesday, August 26, 2020 12:29 PM
To: tianxianting (RD) <tian.xianting@....com>
Cc: axboe@...nel.dk; linux-block@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] blk-mq: use BLK_MQ_NO_TAG for no tag

On Wed, Aug 26, 2020 at 10:06:51AM +0800, Xianting Tian wrote:
> Replace various magic -1 constants for tags with BLK_MQ_NO_TAG.
> And move the definition of BLK_MQ_NO_TAG from 'block/blk-mq-tag.h'
> to 'include/linux/blk-mq.h'

All three symbols are supposed for block core internal code only, so looks you shouldn't move them to public header.


Thanks,
Ming