linux-kernel - Re: Re: [PATCH] media: mx2_emmaprp: Fix memleak in emmaprp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Aug 2020 17:14:35 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Hans Verkuil" <hverkuil-cisco@...all.nl>
Cc:     kjlu@....edu, "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        "Fabio Estevam" <fabio.estevam@....com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] media: mx2_emmaprp: Fix memleak in emmaprp_probe

> On 25/08/2020 11:39, Dinghao Liu wrote:
> > When platform_get_irq() fails, we should release
> > vfd and unregister pcdev->v4l2_dev just like the
> > subsequent error paths.
> > 
> > Fixes: d4e192cc44914 ("media: mx2_emmaprp: Check for platform_get_irq() error")
> > Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> > ---
> >  drivers/media/platform/mx2_emmaprp.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/media/platform/mx2_emmaprp.c b/drivers/media/platform/mx2_emmaprp.c
> > index df78df59da45..2fd31ed86005 100644
> > --- a/drivers/media/platform/mx2_emmaprp.c
> > +++ b/drivers/media/platform/mx2_emmaprp.c
> > @@ -853,7 +853,7 @@ static int emmaprp_probe(struct platform_device *pdev)
> >  
> >  	irq = platform_get_irq(pdev, 0);
> >  	if (irq < 0)
> > -		return irq;
> > +		goto rel_vdev;
> 
> You need to add 'ret = irq;' here, otherwise the platform_get_irq error code
> is not correctly propagated.
> 

Thanks for pointing out that! I'll fix this and resend the patch soon.

Regards,
Dinghao