linux-kernel - [PATCH v2 3/3] iommu/vt-d:Add mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200826105025.3912-4-FelixCui-oc@zhaoxin.com>
Date:   Wed, 26 Aug 2020 06:50:25 -0400
From:   FelixCuioc <FelixCui-oc@...oxin.com>
To:     Joerg Roedel <joro@...tes.org>, <iommu@...ts.linux-foundation.org>,
        <linux-kernel@...r.kernel.org>,
        David Woodhouse <dwmw2@...radead.org>,
        "Lu Baolu" <baolu.lu@...ux.intel.com>,
        Dan Carpenter <dan.carpenter@...cle.com>, <kbuild@...ts.01.org>
CC:     <kbuild-all@...ts.01.org>, <CobeChen-oc@...oxin.com>,
        <RaymondPang-oc@...oxin.com>, <TonyWWang-oc@...oxin.com>
Subject: [PATCH v2 3/3] iommu/vt-d:Add mutex_unlock() before returning

In the probe_acpi_namespace_devices function,when the physical
node of the acpi device is NULL,the unlock function is missing.
Add mutex_unlock(&adev->physical_node_lock).

Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
Signed-off-by: FelixCuioc <FelixCui-oc@...oxin.com>
---
 drivers/iommu/intel/iommu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index b31f02f41c96..25e9853cba1b 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -4851,6 +4851,7 @@ static int __init probe_acpi_namespace_devices(void)
 			if (pn_dev == NULL) {
 				dev->bus->iommu_ops = &intel_iommu_ops;
 				ret = iommu_probe_device(dev);
+				mutex_unlock(&adev->physical_node_lock);
 				if (ret) {
 					pr_err("acpi_device probe fail! ret:%d\n", ret);
 					return ret;
-- 
2.17.1