linux-kernel - Re: [PATCH] [v2] media: mx2_emmaprp: Fix memleak in emmaprp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOMZO5BCZYVj-C70XhwiaWVAZ8ViiBcErRP79eu3=m=aCWvZnw@mail.gmail.com>
Date:   Wed, 26 Aug 2020 08:00:24 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Dinghao Liu <dinghao.liu@....edu.cn>
Cc:     kjlu@....edu, Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Fabio Estevam <fabio.estevam@....com>,
        linux-media <linux-media@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [v2] media: mx2_emmaprp: Fix memleak in emmaprp_probe

Hi Dinghao,

On Wed, Aug 26, 2020 at 6:31 AM Dinghao Liu <dinghao.liu@....edu.cn> wrote:
>
> When platform_get_irq() fails, we should release
> vfd and unregister pcdev->v4l2_dev just like the
> subsequent error paths.
>
> Fixes: d4e192cc44914 ("media: mx2_emmaprp: Check for platform_get_irq() error")
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>

Thanks for the fix:

Reviewed-by: Fabio Estevam <festevam@...il.com>