linux-kernel - Re: [PATCH 1/2] vdpa: ifcvf: return err when fail to request config irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200826071200-mutt-send-email-mst@kernel.org>
Date:   Wed, 26 Aug 2020 07:12:06 -0400
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Jason Wang <jasowang@...hat.com>
Cc:     virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, Zhu Lingshan <lingshan.zhu@...el.com>
Subject: Re: [PATCH 1/2] vdpa: ifcvf: return err when fail to request config
 irq

On Fri, Aug 07, 2020 at 11:52:09AM +0800, Jason Wang wrote:
> 
> On 2020/7/23 下午5:12, Jason Wang wrote:
> > We ignore the err of requesting config interrupt, fix this.
> > 
> > Fixes: e7991f376a4d ("ifcvf: implement config interrupt in IFCVF")
> > Cc: Zhu Lingshan <lingshan.zhu@...el.com>
> > Signed-off-by: Jason Wang <jasowang@...hat.com>
> > ---
> >   drivers/vdpa/ifcvf/ifcvf_main.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
> > index f5a60c14b979..ae7110955a44 100644
> > --- a/drivers/vdpa/ifcvf/ifcvf_main.c
> > +++ b/drivers/vdpa/ifcvf/ifcvf_main.c
> > @@ -76,6 +76,10 @@ static int ifcvf_request_irq(struct ifcvf_adapter *adapter)
> >   	ret = devm_request_irq(&pdev->dev, irq,
> >   			       ifcvf_config_changed, 0,
> >   			       vf->config_msix_name, vf);
> > +	if (ret) {
> > +		IFCVF_ERR(pdev, "Failed to request config irq\n");
> > +		return ret;
> > +	}
> >   	for (i = 0; i < IFCVF_MAX_QUEUE_PAIRS * 2; i++) {
> >   		snprintf(vf->vring[i].msix_name, 256, "ifcvf[%s]-%d\n",
> 
> 
> Hi Michael:
> 
> Any comments on this series?
> 
> Thanks
> 

Applied, thanks!