linux-kernel - Re: [PATCH] perf tools: Use %zd for size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200826115026.GA766106@krava>
Date:   Wed, 26 Aug 2020 13:50:26 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Chris Wilson <chris@...is-wilson.co.uk>,
        linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>, Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexey Budankov <alexey.budankov@...ux.intel.com>
Subject: Re: [PATCH] perf tools: Use %zd for size_t printf formats on 32b

On Fri, Aug 21, 2020 at 09:13:10AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Aug 20, 2020 at 10:25:01PM +0100, Chris Wilson escreveu:
> > A couple of trivial fixes for using %zd for size_t.
> 
> Added Jiri and Namhyung, that are perf tooling reviewers, and Alexey
> Budankov, that added the ZSTD code.
> 
> Applied,
> 
> - Arnaldo
>  
> > Signed-off-by: Chris Wilson <chris@...is-wilson.co.uk>
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > Cc: Ingo Molnar <mingo@...hat.com>
> > cc: Arnaldo Carvalho de Melo <acme@...nel.org>

LGTM

Acked-by: Jiri Olsa <jolsa@...hat.com>

thanks,
jirka

> > ---
> >  tools/perf/util/session.c | 2 +-
> >  tools/perf/util/zstd.c    | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> > index ffbc9d35a383..7a5f03764702 100644
> > --- a/tools/perf/util/session.c
> > +++ b/tools/perf/util/session.c
> > @@ -87,7 +87,7 @@ static int perf_session__process_compressed_event(struct perf_session *session,
> >  		session->decomp_last = decomp;
> >  	}
> >  
> > -	pr_debug("decomp (B): %ld to %ld\n", src_size, decomp_size);
> > +	pr_debug("decomp (B): %zd to %zd\n", src_size, decomp_size);
> >  
> >  	return 0;
> >  }
> > diff --git a/tools/perf/util/zstd.c b/tools/perf/util/zstd.c
> > index d2202392ffdb..48dd2b018c47 100644
> > --- a/tools/perf/util/zstd.c
> > +++ b/tools/perf/util/zstd.c
> > @@ -99,7 +99,7 @@ size_t zstd_decompress_stream(struct zstd_data *data, void *src, size_t src_size
> >  	while (input.pos < input.size) {
> >  		ret = ZSTD_decompressStream(data->dstream, &output, &input);
> >  		if (ZSTD_isError(ret)) {
> > -			pr_err("failed to decompress (B): %ld -> %ld, dst_size %ld : %s\n",
> > +			pr_err("failed to decompress (B): %zd -> %zd, dst_size %zd : %s\n",
> >  			       src_size, output.size, dst_size, ZSTD_getErrorName(ret));
> >  			break;
> >  		}
> > -- 
> > 2.20.1
> > 
> 
> -- 
> 
> - Arnaldo
>