linux-kernel - Re: [PATCH v1] extcon: ptn5150: Deduplicate parts of dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200826122411.GA12977@pi3>
Date:   Wed, 26 Aug 2020 14:24:11 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Vijai Kumar K <vijaikumar.kanagarajan@...il.com>
Subject: Re: [PATCH v1] extcon: ptn5150: Deduplicate parts of dev_err_probe()

On Wed, Aug 26, 2020 at 01:39:10PM +0300, Andy Shevchenko wrote:
> dev_err_probe() is designed to be used like
> 
> 	return dev_err_probe(dev, ret, "Error message\n");
> 
> Hence no need to have a separate return statement. Besides that
> dev_err_probe() prints already returned error code, no need to repeat
> that either.
> 
> Fixes: 48cbf8c6653c ("extcon: ptn5150: Reduce the amount of logs on deferred probe")

It's an code improvement, optimization, but there is no error here to
fix and Fixes tag would trigger backporting to stable. This patch
should not be backported because it does not meet the backporting
requirements.

With Fixes removed:
Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>

Best regards,
Krzysztof