linux-kernel - Re: [PATCH -next] irqchip/ti-sci-intr: Fix unsigned comparison to zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <899af272-8255-9302-c3dd-c632d258f0b9@ti.com>
Date:   Wed, 26 Aug 2020 09:27:27 +0530
From:   Lokesh Vutla <lokeshvutla@...com>
To:     YueHaibing <yuehaibing@...wei.com>, <nm@...com>, <t-kristo@...com>,
        <ssantosh@...nel.org>, <tglx@...utronix.de>,
        <jason@...edaemon.net>, <maz@...nel.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] irqchip/ti-sci-intr: Fix unsigned comparison to
 zero



On 26/08/20 9:23 am, YueHaibing wrote:
> ti_sci_intr_xlate_irq() return -ENOENT on fail, p_hwirq
> should be int type.
> 
> Fixes: a5b659bd4bc7 ("irqchip/ti-sci-intr: Add support for INTR being a parent to INTR")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Thanks for the patch.

Acked-by: Lokesh Vutla <lokeshvutla@...com>

Thanks and regards,
Lokesh

> ---
>  drivers/irqchip/irq-ti-sci-intr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c
> index cbc1758228d9..85a72b56177c 100644
> --- a/drivers/irqchip/irq-ti-sci-intr.c
> +++ b/drivers/irqchip/irq-ti-sci-intr.c
> @@ -137,8 +137,8 @@ static int ti_sci_intr_alloc_parent_irq(struct irq_domain *domain,
>  	struct ti_sci_intr_irq_domain *intr = domain->host_data;
>  	struct device_node *parent_node;
>  	struct irq_fwspec fwspec;
> -	u16 out_irq, p_hwirq;
> -	int err = 0;
> +	int p_hwirq, err = 0;
> +	u16 out_irq;
>  
>  	out_irq = ti_sci_get_free_resource(intr->out_irqs);
>  	if (out_irq == TI_SCI_RESOURCE_NULL)
>