linux-kernel - Re: [RFC v2] perf/core: Fixes hung issue on perf stat command during cpu hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19fac9f1-4662-b695-3bf3-60ddd7133594@google.com>
Date:   Wed, 26 Aug 2020 11:14:25 -0400
From:   Barret Rhoden <brho@...gle.com>
To:     Kajol Jain <kjain@...ux.ibm.com>, acme@...nel.org,
        peterz@...radead.org
Cc:     jolsa@...hat.com, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org, maddy@...ux.ibm.com,
        mingo@...hat.com, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, namhyung@...nel.org,
        daniel@...earbox.net, srikar@...ux.vnet.ibm.com
Subject: Re: [RFC v2] perf/core: Fixes hung issue on perf stat command during
 cpu hotplug

Hi -

On 8/26/20 10:54 AM, Kajol Jain wrote:
> Commit 2ed6edd33a21 ("perf: Add cond_resched() to task_function_call()")
> added assignment of ret value as -EAGAIN in case function
> call to 'smp_call_function_single' fails.
> For non-zero ret value, it did
> 'ret = !ret ? data.ret : -EAGAIN;', which always
> assign -EAGAIN to ret and make second if condition useless.
> 
> In scenarios like when executing a perf stat with --per-thread option, and
> if any of the monitoring cpu goes offline, the 'smp_call_function_single'
> function could return -ENXIO, and with the above check,
> task_function_call hung and increases CPU
> usage (because of repeated 'smp_call_function_single()')
> 
> Recration scenario:
> 	# perf stat -a --per-thread && (offline a CPU )
> 
> Patch here removes the tertiary condition added as part of that
> commit and added a check for NULL and -EAGAIN.
> 
> Fixes: 2ed6edd33a21("perf: Add cond_resched() to task_function_call()")
> Signed-off-by: Kajol Jain <kjain@...ux.ibm.com>
> Reported-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
> ---
>   kernel/events/core.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Changelog:
> - Remove addition of else in the first patch for
>    if(ret != -EAGAIN) condition.
> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 856d98c36f56..fe104fee097a 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -115,8 +115,8 @@ task_function_call(struct task_struct *p, remote_function_f func, void *info)
>   	for (;;) {
>   		ret = smp_call_function_single(task_cpu(p), remote_function,
>   					       &data, 1);
> -		ret = !ret ? data.ret : -EAGAIN;
> -
> +		if(!ret)
                   ^
Minor nit, you need a space after the if.

Also, the comment for the function says it returns @func's return val or 
-ESRCH.  You could also add -ENXIO to that.

Thanks for the fix.

Reviewed-by: Barret Rhoden <brho@...gle.com>

> +			ret = data.ret;
>   		if (ret != -EAGAIN)
>   			break;
>   
>