linux-kernel - RE: [PATCH v2 06/10] fs/ntfs3: Add compression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <637da0b964ee4bda8d1d31a33ec659e5@paragon-software.com>
Date:   Thu, 27 Aug 2020 15:54:44 +0000
From:   Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>
CC:     Pali Rohár <pali@...nel.org>
Subject: RE: [PATCH v2 06/10] fs/ntfs3: Add compression

From: Randy Dunlap <rdunlap@...radead.org>
Sent: Friday, August 21, 2020 7:46 PM
> 
[] 
> > +// 0x3FFF
> > +#define HeaderOfNonCompressedChunk ((LZNT_CHUNK_SIZE + 2 - 3) | 0x3000)
> 
> Do we need something in coding-style.rst that says:
> 	Avoid CamelCase in Linux kernel source code.
> ?

Hi! Thanks. Will get rid of it in v3.

> 
> > +
> > +/*
> > + * compess_chunk
> 
> Just curious: what is this compess name?
> 
> > + *
> > + * returns one of the tree values:
> 
> s/tree/three/
> 
[]

Will be fixed in v3.