linux-kernel - RE: [EXT] Re: [PATCH v2] mwifiex: don't call del_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB4366AFB378F2AC506D8565848F550@VI1PR04MB4366.eurprd04.prod.outlook.com>
Date:   Thu, 27 Aug 2020 04:50:00 +0000
From:   Ganapathi Bhat <ganapathi.bhat@....com>
To:     Brian Norris <briannorris@...omium.org>,
        Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
CC:     amit karwar <amitkarwar@...il.com>,
        Andrey Konovalov <andreyknvl@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Xinming Hu <huxinming820@...il.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Linux USB Mailing List <linux-usb@...r.kernel.org>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        "<netdev@...r.kernel.org>" <netdev@...r.kernel.org>,
        Nishant Sarmukadam <nishants@...vell.com>,
        "syzkaller-bugs@...glegroups.com" <syzkaller-bugs@...glegroups.com>,
        syzbot <syzbot+373e6719b49912399d21@...kaller.appspotmail.com>,
        syzbot <syzbot+dc4127f950da51639216@...kaller.appspotmail.com>
Subject: RE: [EXT] Re: [PATCH v2] mwifiex: don't call del_timer_sync() on
 uninitialized timer

Hi Tetsuo,

> > "grep -FrB1 'del_timer' drivers/ | grep -FA1 '.function)'" says that
> > currently there are 28 locations which call del_timer[_sync]() only if
> > that timer's function field was initialized (because timer_setup()
> > sets that timer's function field). Therefore, let's use same approach here.

Thanks for the change, it look cleaner than my re-work;

Acked-by: Ganapathi Bhat <ganapathi.bhat@....com>

Regards,
Ganapathi