lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Aug 2020 09:11:49 -0700 (PDT) From: David Miller <davem@...emloft.net> To: linmiaohe@...wei.com Cc: kuba@...nel.org, pshelar@....org, fw@...len.de, martin.varghese@...ia.com, edumazet@...gle.com, dcaratti@...hat.com, steffen.klassert@...unet.com, pabeni@...hat.com, shmulik@...anetworks.com, kyk.segfault@...il.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: Call ip_hdrlen() when skbuff is not fragment From: Miaohe Lin <linmiaohe@...wei.com> Date: Thu, 27 Aug 2020 07:17:59 -0400 > When skbuff is fragment, we exit immediately and leave ip_hdrlen() as > unused. And remove the unnecessary local variable fragment. > > Signed-off-by: Miaohe Lin <linmiaohe@...wei.com> I don't think this is a useful optimization sorry, the common case will be just as likely to be a fragment as not so it's arbitrary whether we read this simple value or not. I'm not applying this, sorry.
Powered by blists - more mailing lists