linux-kernel - RE: [PATCH v2 00/10] fs: NTFS read-write driver GPL implementation by Paragon Software.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8dc38559e18f43238e5b4cba533963cd@paragon-software.com>
Date:   Thu, 27 Aug 2020 16:12:45 +0000
From:   Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To:     Joe Perches <joe@...ches.com>,
        "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>
CC:     Pali Rohár <pali@...nel.org>
Subject: RE: [PATCH v2 00/10] fs: NTFS read-write driver GPL implementation by
 Paragon Software.

From: Joe Perches <joe@...ches.com>
Sent: Friday, August 21, 2020 10:21 PM
> 
> On Fri, 2020-08-21 at 16:24 +0000, Konstantin Komarov wrote:
> > This patch adds NTFS Read-Write driver to fs/ntfs3.
> 
> Thanks.
> Proper ntfs read/write support will be great addition.
> 
> Trivia:
> 
> If this patchset is submitted again with a new version,
> please use something like "git format-patch --cover-letter"
> and "git send-email" so all parts of the patches and replies
> have the a single message thread to follow.
> 
> That will add an "in-reply-to" header of the 0/m patch
> message-id to all n/m parts.
> 

Hi Joe! Thanks a lot. Will use git send-email for V3. format-patch and --cover-letter have been already used for v2.

> One style oddity I noticed is the use of goto labels in
> favor of if block indentation.  It's not terrible style,
> just unusual for kernel code.
> 

AFAIK goto's are being quite widely used in kernel code as well. However V3 will introduce several goto's replacements with if blocks.

Thanks!