linux-kernel - Re: [PATCH net v4] net: ethernet: ti: cpsw_new: fix error handling in cpsw_ndo_vlan_rx_kill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 Aug 2020 09:16:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     m-karicheri2@...com
Cc:     kuba@...nel.org, grygorii.strashko@...com, nsekhar@...com,
        linux-omap@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v4] net: ethernet: ti: cpsw_new: fix error handling
 in cpsw_ndo_vlan_rx_kill_vid()

From: Murali Karicheri <m-karicheri2@...com>
Date: Thu, 27 Aug 2020 10:38:39 -0400

> This patch fixes a bunch of issues in cpsw_ndo_vlan_rx_kill_vid()
> 
>  - pm_runtime_get_sync() returns non zero value. This results in
>    non zero value return to caller which will be interpreted as error.
>    So overwrite ret with zero.
>  - If VID matches with port VLAN VID, then set error code.
>  - Currently when VLAN interface is deleted, all of the VLAN mc addresses
>    are removed from ALE table, however the return values from ale function
>    calls are not checked. These functions can return error code -ENOENT.
>    But that shouldn't happen in a normal case. So add error print to
>    catch the situations so that these can be investigated and addressed.
>    return zero in these cases as these are not real error case, but only
>    serve to catch ALE table update related issues and help address the
>    same in the driver.
> 
> Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac")
> Signed-off-by: Murali Karicheri <m-karicheri2@...com>

Applied and queued up for -stable, thanks.