linux-kernel - Re: [PATCH v3 2/3] usb typec: mt6360: Rename driver/Kconfig/Makefile from mt6360 to mt636x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200827164131.GA86149@roeck-us.net>
Date:   Thu, 27 Aug 2020 09:41:31 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     cy_huang <u0084500@...il.com>
Cc:     gregkh@...uxfoundation.org, robh+dt@...nel.org,
        matthias.bgg@...il.com, heikki.krogerus@...ux.intel.com,
        cy_huang@...htek.com, gene_chen@...htek.com,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/3] usb typec: mt6360: Rename driver/Kconfig/Makefile
 from mt6360 to mt636x

On Thu, Aug 27, 2020 at 07:18:56PM +0800, cy_huang wrote:
> From: ChiYuan Huang <cy_huang@...htek.com>
> 
> 1. Rename file form tcpci_mt6360.c to tcpci_mt636x.c
> 2. Rename internal function from mt6360 to mt636x, except the register
> definition.
> 3. Change Kconfig/Makefile from MT6360 to MT636X.
> 
> Signed-off-by: ChiYuan Huang <cy_huang@...htek.com>
> ---
>  drivers/usb/typec/tcpm/Kconfig        |   6 +-
>  drivers/usb/typec/tcpm/Makefile       |   2 +-
>  drivers/usb/typec/tcpm/tcpci_mt6360.c | 212 ----------------------------------
>  drivers/usb/typec/tcpm/tcpci_mt636x.c | 212 ++++++++++++++++++++++++++++++++++
>  4 files changed, 216 insertions(+), 216 deletions(-)
>  delete mode 100644 drivers/usb/typec/tcpm/tcpci_mt6360.c
>  create mode 100644 drivers/usb/typec/tcpm/tcpci_mt636x.c

Maybe Heikki is ok with this change, but I am not, for the reasons
mentioned before. So I won't approve this patch. Note that, either
case, it should be merged with the first patch.

Guenter