lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Aug 2020 20:58:20 +0200 From: Krzysztof Kozlowski <krzk@...nel.org> To: Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <bgolaszewski@...libre.com>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Hans de Goede <hdegoede@...hat.com>, Bastien Nocera <hadess@...ess.net>, Sangwon Jee <jeesw@...fas.com>, Eugen Hristev <eugen.hristev@...rochip.com>, Andy Shevchenko <andy.shevchenko@...il.com>, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, linux-input@...r.kernel.org, platform-driver-x86@...r.kernel.org, clang-built-linux@...glegroups.com Cc: Krzysztof Kozlowski <krzk@...nel.org> Subject: [PATCH v3 18/27] Input: resistive-adc-touch - Simplify with dev_err_probe() Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org> Reviewed-by: Hans de Goede <hdegoede@...hat.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com> --- drivers/input/touchscreen/resistive-adc-touch.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/input/touchscreen/resistive-adc-touch.c b/drivers/input/touchscreen/resistive-adc-touch.c index cfc8bb4553f7..46b5a6caef84 100644 --- a/drivers/input/touchscreen/resistive-adc-touch.c +++ b/drivers/input/touchscreen/resistive-adc-touch.c @@ -108,12 +108,8 @@ static int grts_probe(struct platform_device *pdev) /* get the channels from IIO device */ st->iio_chans = devm_iio_channel_get_all(dev); - if (IS_ERR(st->iio_chans)) { - error = PTR_ERR(st->iio_chans); - if (error != -EPROBE_DEFER) - dev_err(dev, "can't get iio channels.\n"); - return error; - } + if (IS_ERR(st->iio_chans)) + return dev_err_probe(dev, PTR_ERR(st->iio_chans), "can't get iio channels\n"); chan = &st->iio_chans[0]; st->pressure = false; -- 2.17.1
Powered by blists - more mailing lists