linux-kernel - Re: [PATCH v2] x86/pci: fix intel_mid_pci.c build error when ACPI is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200827190517.GA2097725@bjorn-Precision-5520>
Date:   Thu, 27 Aug 2020 14:05:17 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        linux-pci <linux-pci@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        stable <stable@...r.kernel.org>,
        Jacob Pan <jacob.jun.pan@...ux.intel.com>,
        Len Brown <lenb@...nel.org>,
        Jesse Barnes <jsbarnes@...gle.com>,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Adam Borowski <kilobyte@...band.pl>
Subject: Re: [PATCH v2] x86/pci: fix intel_mid_pci.c build error when ACPI is
 not enabled

On Fri, Aug 21, 2020 at 05:10:27PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix build error when CONFIG_ACPI is not set/enabled by adding
> the header file <asm/acpi.h> which contains a stub for the function
> in the build error.
> 
> ../arch/x86/pci/intel_mid_pci.c: In function ‘intel_mid_pci_init’:
> ../arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration]
>   acpi_noirq_set();
> 
> Fixes: a912a7584ec3 ("x86/platform/intel-mid: Move PCI initialization to arch_init()")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: stable@...r.kernel.org	# v4.16+
> Cc: Jacob Pan <jacob.jun.pan@...ux.intel.com>
> Cc: Len Brown <lenb@...nel.org>
> To: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Jesse Barnes <jsbarnes@...gle.com>
> Cc: Arjan van de Ven <arjan@...ux.intel.com>
> Cc: linux-pci@...r.kernel.org
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> Reviewed-by: Jesse Barnes <jsbarnes@...gle.com>
> Acked-by: Thomas Gleixner <tglx@...utronix.de>

Applied to pci/misc for v5.10, thanks!

We could put it in v5.9, but a912a7584ec3 was merged for v4.16, so
apparently this has been broken for a long time.

> ---
> Found in linux-next, but applies to/exists in mainline also.
> 
> v2:
> - add Reviewed-by: and Acked-by: tags
> - drop alternatives
> 
>  arch/x86/pci/intel_mid_pci.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20200813.orig/arch/x86/pci/intel_mid_pci.c
> +++ linux-next-20200813/arch/x86/pci/intel_mid_pci.c
> @@ -33,6 +33,7 @@
>  #include <asm/hw_irq.h>
>  #include <asm/io_apic.h>
>  #include <asm/intel-mid.h>
> +#include <asm/acpi.h>
>  
>  #define PCIE_CAP_OFFSET	0x100
>  
>