linux-kernel - Re: [PATCH] hwmon: gsc-hwmon: scale temperature to millidegrees

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200827194848.GA232549@roeck-us.net>
Date:   Thu, 27 Aug 2020 12:48:48 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Tim Harvey <tharvey@...eworks.com>
Cc:     Jean Delvare <jdelvare@...e.com>,
        Robert Jones <rjones@...eworks.com>,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] hwmon: gsc-hwmon: scale temperature to millidegrees

On Thu, Aug 27, 2020 at 10:20:24AM -0700, Tim Harvey wrote:
> The GSC registers report temperature in decidegrees celcius so we
> need to scale it to represent the hwmon sysfs API of millidegrees.
> 
> Cc: stable@...r.kernel.org
> Signed-off-by: Tim Harvey <tharvey@...eworks.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/gsc-hwmon.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwmon/gsc-hwmon.c b/drivers/hwmon/gsc-hwmon.c
> index 3dfe2ca..c6d4567 100644
> --- a/drivers/hwmon/gsc-hwmon.c
> +++ b/drivers/hwmon/gsc-hwmon.c
> @@ -172,6 +172,7 @@ gsc_hwmon_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,
>  	case mode_temperature:
>  		if (tmp > 0x8000)
>  			tmp -= 0xffff;
> +		tmp *= 100; /* convert to millidegrees celsius */
>  		break;
>  	case mode_voltage_raw:
>  		tmp = clamp_val(tmp, 0, BIT(GSC_HWMON_RESOLUTION));